Repository navigation
NUTCH-2887 Migrate to JUnit 5 Jupiter - #861
Merged
Merged
Conversation
lewismc
marked this pull request as draft
September 4, 2025 15:46
lewismc
marked this pull request as ready for review
September 5, 2025 03:29
Member
Author
|
Phase 1 is ready to test locally. Again, this PR is limited to adjusting the JUnit dependencies and associated Ant configuration in order to have the JUnit 5 engine run the existing JUnit 4 tests in |
sebastian-nagel
approved these changes
Sep 5, 2025
sebastian-nagel
left a comment
Contributor
There was a problem hiding this comment.
+1
Tests compile and run locally.
Definitely a good approach to split the implementation into steps. Even smaller steps would be better than nothing, if they are not trivial, for example the tests of parse-tika.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whats in this PR?
Phase 1 of NUTCH-2887 which
junit-vintage-enginewhich allows us to run JUnit 4 tests as we gradually migratecoreandpluginsto JUnit 5.<junit>Ant task with<junitlauncherfor thetest-coreAnt target.Next steps
Phase 2 - core
coretests with JUnit 5 implementations.coretests which will reduce duplicate boilerplate and improve test filtering.Phase 3 - core
Same as in core above but replace
corewithplugins.Questions
Thanks for any comments. 👍